rjmccall added inline comments.
================
Comment at: include/clang/Basic/FixedPoint.h:64
+
+class APFixedPoint {
+ public:
----------------
rjmccall wrote:
> This should get a documentation comment describing the class. You should
> mention that, like `APSInt`, it carries all of the semantic information about
> the value's type (width, signed-ness, saturating-ness, etc.), but by design
> it does not carry the original C type — among other reasons, so that it can
> more easily be moved to LLVM should fixed-point types gain native IR support.
Documentation comments start with ///.
Otherwise, these changes look good; LGTM, but of course you should settle
Bevin's review comments before committing.
Repository:
rC Clang
https://reviews.llvm.org/D48661
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
