asb accepted this revision. asb added a comment. Herald added a subscriber: rkruppe.
This looks good to me with two caveats - the tests don't seem to check that the "machine" is the default mode when the "interrupt" attribute has no arguments. - Although the conversion from RISCVInterruptAttr::user to "user" etc is trivial, it would probably be worth testing the emitted attributes are as expected? https://reviews.llvm.org/D48412 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
