lebedev.ri added inline comments.

================
Comment at: lib/CodeGen/CodeGenFunction.h:383
+  // This stack is used/maintained exclusively by the implicit cast sanitizer.
+  llvm::SmallVector<const CastExpr *, 8> CastExprStack;
+
----------------
vsk wrote:
> lebedev.ri wrote:
> > vsk wrote:
> > > Why not 0 instead of 8, given that in the common case, this stack is 
> > > unused?
> > No longer relevant.
> I'm referring to CastExprStack within ScalarExprEmitter, which still 
> allocates space for 8 pointers inline.
Ah, you mean in the general case when the sanitizer is disabled?



Repository:
  rC Clang

https://reviews.llvm.org/D48958



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to