On Mar 2, 2008, at 10:05 AM, Nuno Lopes wrote: >> Please keep in 80 cols. > > k, sorry. I simply don't have any editor that can simply draw a > vertical line on the 80 cols.. > >> + if (FD->getAttr<NothrowAttr>()) >> + ParamAttrsVec.push_back( >> + llvm::ParamAttrsWithIndex::get(ParamAttrsVec.size(), >> llvm::ParamAttr::NoUnwind)); >> + if (FD->getAttr<NoReturnAttr>()) >> + ParamAttrsVec.push_back( >> + llvm::ParamAttrsWithIndex::get(ParamAttrsVec.size(), >> llvm::ParamAttr::NoReturn)); >> + >> >> More 80 col violations. I think these attributes should always be >> applied to "0", the function itself, so the first arg should be 0, >> not ParamAttrsVec.size(). Try a function that is both noreturn >> and nounwind. > > Actually both failed when defining a function with noreturn and > nothrow. They both throw a weird error on LLVM structures.. Do you > mind checking this, please? > > I've updated the patch to incorporate some of your feedback + simple > handling of dllimport/dllexport and visibility.
Applied, thanks! http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20080225/004508.html I'll investigate the nothrow+noreturn issue. -Chris _______________________________________________ cfe-dev mailing list [email protected] http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
