Comment #6 on issue 6437 by bugdro...@chromium.org: Autocomplete popup
should show up for Down/Up arrow key, if the input field regains focus.
http://code.google.com/p/chromium/issues/detail?id=6437
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=12428
------------------------------------------------------------------------
r12428 | jcam...@chromium.org | 2009-03-24 18:15:03 -0700 (Tue, 24 Mar
2009) | 14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/editor_client_impl.cc?r1=12428&r2=12427
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/editor_client_impl.h?r1=12428&r2=12427
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.cc?r1=12428&r2=12427
When in a form text field, pressing the up/down arrow keys should bring up
the autofill popup.
Pressing up would not trigger that behavior.
This happened because the default processing of the up arrow key is to move
the caret to the beginning of the text input.
Showing the autofill is done as a posted task.
Because the caret was not at the end of the text-field by the time that
task got executed, the popup would not show.
The fix is to not default process the up/down arrow key messages when an
autofill popup will be shown.
Also fixed the WebViewImpl::HideAutoCompletePopup (harmless bug, calling it
twice would cause it to hide the already hidden popup).
BUG=6437
TEST=Make sure up/down arrow keys trigger the autofill menu correctly
(especially when there is already text in the text-field). Make sure
autofill still works as expected.
Review URL: http://codereview.chromium.org/53017
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
