Updates:
        Cc: fin...@chromium.org

Comment #3 on issue 15615 by s...@chromium.org: Crash -  
browser_shutdown::OnShutdownStarting(browser_shutdown::ShutdownType)
http://code.google.com/p/chromium/issues/detail?id=15615

Finnur asked if it's possible we're adding a NULL RPH to the hashtable  
(all_hosts). It's
certainly possible. The only place things are added to the map is here:

void RenderProcessHost::SetProcessID(int pid) {
   if (pid_ != -1) {
     // This object is being reused after a renderer crash.  Remove the old  
pid.
     all_hosts.Remove(pid_);
   }

   pid_ = pid;
   all_hosts.AddWithID(this, pid);
}

To get NULL in the map would require this to be NULL. It's worth a CHECK.

I think we should instrument the code in the following ways to figure out  
what's
happening:

1. Add the option to id_map to CHECK on inserting NULL. RPH would turn this  
on.
2. Modify browser_shutdown to make sure the size of all_hosts doesn't  
change while
iterating through the RPH iterator.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to