Comment #23 on issue 20371 by [email protected]: about:crash crashes  
browser process
http://code.google.com/p/chromium/issues/detail?id=20371

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=25371

------------------------------------------------------------------------
r25371 | [email protected] | 2009-09-03 14:27:36 -0700 (Thu, 03 Sep 2009) |  
18 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util.h?r1=25371&r2=25370
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_mac.mm?r1=25371&r2=25370
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/base/process_util_posix.cc?r1=25371&r2=25370

When forking, restore the default exception handler port.

The browser process launches children with fork && exec.  On the Mac, this
results in a child that has its exception ports set the same as the parent.
When Breakpad is enabled, this means that a child such as a renderer process
begins its life with its exception port pointing to a Breakpad instance
running inside the browser.  This is not intended.  Even if the child  
installs
its own Breakpad handler (which a renderer would), the previous handler  
would
be pointing to the instance inside the browser, and if the child's Breakpad
is misconfigured to pass exceptions to the previous handler it will wind up
being passed back to the parent.  The misconfiguration was corrected in  
r25311.
This change restores the default exception handler port, which should be
Apple Crash Reporter/ReportCrash, in the child process immediately after it
it has been forked.

BUG=20371
TEST=None, because r25311 fixed the visible aspect of this bug
Review URL: http://codereview.chromium.org/200007
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to