Hey AGL, can you link me with your code review for some of your View ports, so I can see how you did them? So is it final to do platform independent views? That being said, a lot of refactoring should be done to reuse code.
Thanks, On Tue, Dec 16, 2008 at 11:36 AM, Adam Langley <a...@chromium.org> wrote: > > On Tue, Dec 16, 2008 at 8:07 AM, Josh Roesslein <jroessl...@gmail.com> > wrote: > > We would have to abstract the "windows.h" header in these headers. For > > example the HWND type from windows.h could > > be moved into views_basetypes.h and use an #if-def to dfine it: > > > > #if defined(WINDOWS) > > #include <windows.h> > > #elseif defined(GTK) > > typedef unsigned int HWND > > #endif > > > > Something like that could work. Bascially any types defined in > <windows.h> > > could be defined for the other platforms. > > The typedefed HWND is "NativeView" (in base/gfx/native_widget_types.h). > > > Another side note, using GTK will also help in the porting to Mac OSX. > > > > Next we could divide the .cc files into the different platforms. > > views/windows - holds all .cc files that implement for windows > > views/gtk - holds all .cc files that implement for the gtk toolkit > > Rather than directories we generally use xxx.cc (platform independent) > and xxx_win.cc/xxx_skia.cc/xxx_linux.cc. At least that's the pattern > that we maintain because of WebKit. > > The Mac folks will be doing their own thing which I doubt involves GTK :) > > > AGL > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to chromium-dev@googlegroups.com To unsubscribe from this group, send email to chromium-dev+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
