It looks like everyone and their dog adds init code to the startup
sequence. This takes the form of first time initialization, command
line switch parsing, etc. Is there any special reason why it's done in
the startup flow vs. in a static method the first time a service is
created or used?
I think moving a lot of this stuff out of the following places:
BrowserMain
BrowserInit::LaunchWithProfile::Launch
BrowserInit::LaunchBrowserImpl
... might make the startup flow easier to understand. As it stands,
there's first-time init code for various services sprinkled across
these methods and it's not clear why they are done in one function and
not another - since there aren't any explanatory comments it seems a
case of "i'll just shove this here for now".
It seems like adding some phase notifications here might also help.
Also, does anyone know why BrowserInit::MessageWindow is inside
BrowserInit? It seems to be only used by BrowserMain. BrowserInit is
higher level and has to do with the creation of the initial set of
browser windows.
-Ben
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
