There is one thing though, I don't think hclam checkin turned any Linux
tests red. The linux build was unusable, but the unit tests and layout tests
were passing. It seems like there is a lack of tests here.
When I woke up I reverted his change because it broke Purify on windows and
another unit test on windows, on only 1 bot. There is a possibility that he
did wait, but did not judge that the tree was red enough to worry about it.
(the unit test did look like a flakyness, and Purify is often slow to give
results).
I learned just after the revert that it did fix the problem with linux.
So, my recommendations:
1. hclam: don't resubmit until you are sure it does not break linux. I'm
sure any linux people here can help you with this.
2. linux people: We need more tests.
3. Everyone: If the tree is broken, and no sheriff is around, please, try to
find what broke it, and revert the change.
If the tree is broken because of a problem with the buildbots, and no one is
around to fix it, you can also page me. (I'll add the email alias to my who
page).
Nicolas
On Thu, Mar 5, 2009 at 8:47 AM, Amanda Walker <ama...@chromium.org> wrote:
>
> On Thu, Mar 5, 2009 at 11:41 AM, Dean McNamee <de...@chromium.org> wrote:
> > Maybe we need to limit the hours people are commit, if a sheriff isn't
> > around to fix things? I don't really think that's a good strategy
> > either. I don't know.
>
> Well, it's not the sheriff's responsibility to fix every checkin,
> they're just there as a safety net. All of us should be making sure
> we don't break the build, every time we commit something. I don't
> think limiting commit hours is a workable strategy, given how many
> people are working across so many time zones. However, last night was
> a good reminder that no one should ever commit and then leave without
> watching the build to make sure it landed cleanly. It just leaves a
> mess for other people, which is unfriendly.
>
> --Amanda
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
