In this case, because the method will be part of the WebKit API, we'll have natural reluctance to remove the method. In general, however, I don't know that a comment like that is enough. It doesn't give me a way to eventually delete the method if it should become unnecessary to you. I think the only solution is for you to add a consumer to the Chromium code base, and then setup a buildbot that builds and preferably exercises that consumer. Then, if someone sees the function, they will be able to know who cares about it.
Without something like that, you can be pretty much guaranteed to repeat this experience in the future. Regards, -Darin On Mon, Jul 6, 2009 at 11:09 AM, Marshall Greenblatt <magreenbl...@gmail.com > wrote: > On Mon, Jul 6, 2009 at 2:02 PM, Darin Fisher <da...@chromium.org> wrote: > >> Sorry for deleting this function. I searched the Chromium code base and >> saw no consumer, so I assumed it was dead code. I do that from time to >> time, and so I'm concerned about how to avoid this problem in the future. > > > I've been thinking about that too. Maybe we should mention in the method > comment that it's used by an external consumer? > > >> >> -Darin >> >> >> On Sat, Jul 4, 2009 at 6:58 PM, Marshall Greenblatt < >> magreenbl...@gmail.com> wrote: >> >>> On Sat, Jul 4, 2009 at 6:41 PM, Marshall Greenblatt < >>> magreenbl...@gmail.com> wrote: >>> >>>> Hi Darin, >>>> >>>> Your rev 19669 removes the WebFrame::GetPrintPageShrink() method that >>>> was added in rev 14639: >>>> >>>> http://src.chromium.org/viewvc/chrome?view=rev&revision=14639 >>>> >>>> --- begin paste --- >>>> >>>> Rev 12100 changed the way that we spool and render printed output, most >>>> notably >>>> introducing use of the PrintContext class. The existing >>>> PrintContext::spoolPage() method applies a webkit scaling factor before >>>> rendering output to the graphics context. >>>> ChromePrintContext::spoolPage() (in >>>> webframe_impl.cc), which is used by chromium instead of >>>> PrintContext::spoolPage(), does not apply this scaling factor, but >>>> instead >>>> eventually returns the scaling factor via WebFrame::PrintPage(). This >>>> is a >>>> problem for the Chromium Embedded Framework (CEF) because, unlike >>>> chromium, the >>>> CEF renders directly to the printer device context. It is therefore >>>> important >>>> for CEF that we retrieve and apply the webkit scaling factor before >>>> calling >>>> PrintPage(). In order to support this capability the following adds a >>>> WebFrame::GetPrintPageShrink() method. >>>> >>>> --- end paste --- >>>> >>>> Can you please restore the WebFrame::GetPrintPageShrink() method or >>>> provide an alternate approach for meeting the described need? >>> >>> >>> A patch to restore this method is available here: >>> >>> http://codereview.chromium.org/149186 >>> >>> >>> >>>> >>>> >>>> Thanks, >>>> Marshall >>>> >>> >>> >> > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
