On this same subject -- do we do any lossy compression in our png encoding? I think we should *not*. Developers will be peeved if their carefully compressed images come out looking different because of our internal implementation details.
- a On Fri, Jul 10, 2009 at 1:17 PM, Avi Drissman<a...@google.com> wrote: > Nailed: http://codereview.chromium.org/149473 > > Avi > > On Fri, Jul 10, 2009 at 4:15 PM, Amanda Walker <ama...@chromium.org> wrote: >> >> On Fri, Jul 10, 2009 at 3:54 PM, Avi Drissman<a...@google.com> wrote: >> > Two things. First, this doesn't happen on Windows. Second, how do you >> > get an >> > image shifted one pixel to the right? On the Mac, ImageDecoder::Decode >> > uses >> > the webkit decoders which on the Mac return a CGImage, and then >> > gfx::CGImageToSkBitmap is called. >> >> Well, all platforms use the webkit decoders (as of Darin's refactoring >> in January), they just return different the image differently. >> gfx::CGImageToSkBitmap does sound like a likely culprit, though :-). >> >> --Amanda > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
