I'm working on gclient to pass the matching file list to the hook, or some
equivalent.
I discovered another issue, which I highly suspect is caused by a build
issue (I'm not sure if it's the same issue).
waiting_animation_frames = rb.GetBitmapNamed(IDR_THROBBER_WAITING);
DCHECK(waiting_animation_frames);
DCHECK(waiting_animation_frames->width() %
waiting_animation_frames->height() == 0); // <-- this DCHECK
fails
waiting_animation_frame_count =
waiting_animation_frames->width() / waiting_animation_frames-
>height();
It seems that a wrong bitmap is being loaded. What can it mean for the
build?
On Mon, Jul 27, 2009 at 16:54, Paweł Hajdan Jr. <phajdan...@chromium.org>wrote:
> I'm going to try writing the hook, but I would first ask for advice.
> The hook syntax takes a filename pattern and a command. So I would have to
> create a new command (probably in src/tools), like clobber_generated_headers
> or something similar.
>
> And the tool itself does not get the list of changed files, so it has to
> clobber all of them, and have the list of files to be clobbered hardcoded.
>
> Do you see better solutions?
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
