I don't think so.  It looks like VS doesn't rebuild files when the
compiler invocation to build them would change.  Michael added a new
macro definition on the command line.

If that's the case, this would be a VS problem (I'd call it a bug),
and I'm not sure how easy it would be to work around in GYP.

Jeremy Orlow wrote:
> Brad, looks like we might have another dependency bug in GYP?
> J
>
> On Wed, Aug 12, 2009 at 1:57 PM, Michael Nordman <micha...@google.com>
> wrote:
>>
>> I just submitted the change that ENABLE's that flag a moment ago... we're
>> clobbering things now
>>
>> On Wed, Aug 12, 2009 at 1:55 PM, Jeremy Orlow <jor...@google.com> wrote:
>>>
>>> Clobber needed?
>>> I know Michael just enabled this within the last 24 hours.
>>>
>>> On Wed, Aug 12, 2009 at 1:49 PM, Paweł Hajdan Jr.
>>> <phajdan...@chromium.org> wrote:
>>>>
>>>> Just got this on the Windows tryserver:
>>>> C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc :
>>>> error C2220: warning treated as error - no 'object' file generated
>>>> C:\b\slave\win\build\src\chrome\renderer\renderer_webkitclient_impl.cc :
>>>> warning C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for
>>>> precompiled header but not for current compile
>>>> render_thread.cc
>>>> C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : error C2220:
>>>> warning treated as error - no 'object' file generated
>>>> C:\b\slave\win\build\src\chrome\renderer\render_thread.cc : warning
>>>> C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled
>>>> header but not for current compile
>>>> renderer_glue.cc
>>>> C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : error C2220:
>>>> warning treated as error - no 'object' file generated
>>>> C:\b\slave\win\build\src\chrome\renderer\renderer_glue.cc : warning
>>>> C4651: '/DENABLE_OFFLINE_WEB_APPLICATIONS=1' specified for precompiled
>>>> header but not for current compile
>>>> It's a bit annoying... Is it easily fixable?

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to