On Wed, Aug 19, 2009 at 1:14 PM, Evan Martin <e...@chromium.org> wrote:
> > Rad that you're doing this! > > I think that we shouldn't have any linux-specific directories except > for one or two cases where it's *really* Linux-specific (like crash > dumping or ). So the same should be true for you. > > It seems the configurations we'll see most frequently in code are: > 1) POSIX (basically, non-Windows -- we have this already) > 2) POSIX minus Mac (since Mac has the most extensions, especially at > the GUI layer) > 3) POSIX minus Linux (aka everything BSD-derived, more or less) > > Dean proposes a define for #2, agl proposes a define for #3. I think > it'd be nice to keep the defines down if possible. > > I wonder if #2 could be covered by OS_POSIX && TOOLKIT_GTK. Or, > What about TOOLKIT_VIEWS? > elsewhere in the code, we already do something like > #ifdef OS_MAC > #elif OS_POSIX // with an implied !OS_MAC due to the first branch > > So I think I'm agreeing with Adam that we want OS_BSD and from there > if there's ever a situation where you're listing more than one > platform in a preprocessor conditional, revisiting this issue. > > On Wed, Aug 19, 2009 at 11:43 AM, Ben Laurie<b...@chromium.org> wrote: > > I've started working on a FreeBSD port. The first patch is > > here: http://codereview.chromium.org/172032. > > When looking at the patch, bear in mind a couple of things... > > 1. Added gyp lines for files like *_ar.pak are compensating for the fact > > that i18n targets are not currently being handled correctly, and this can > > break the build, particularly when -j is not used. There are TODOs to > make > > them work properly. They aren't really part of the port, but because I > have > > no build farm for FreeBSD, the problems show up. > > 2. There are now some directories that are called "linux" or "mac" but > are > > used for FreeBSD, too. I'm hesitant to rename these at this point, > because > > it may turn out later that actually FreeBSD-specific versions are needed. > > Views welcome, of course. > > Anyway, there's been some debate about how to proceed in terms of ifdefs. > > The observation is that many places that are currently: > > #if defined(OS_LINUX) > > are going to become: > > #if defined(OS_LINUX) || defined(OS_FREEBSD) > > and this is ugly. > > There's a temptation to instead say these are both POSIX, but not MACOSX, > > for example as here: > > http://codereview.chromium.org/172032/diff/3003/3013 > > but this may not always be true (to be honest, I'm not even sure if its > true > > for that case). > > Does the list have a view on how this should be handled? > > > > > > > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
