On Mon, Aug 31, 2009 at 9:17 AM, Mark Mentovai<m...@chromium.org> wrote:
> Evan Martin wrote:
>> This cache is in-memory only, right? That is, it's generated during startup?
>> (In the past I've talked about caches but I'm worried that the NTP
>> positioning will jump around due to stale caches, since the site
>> ranking is based on day granularity. Though that could be considered
>> a design flaw.)
>
> Right now, I'm hanging a new method on NewTabHTMLSource to generate
> the data and store it in a member. I'm calling that from the NTHS
> constructor, and I'm doing the same thing for the CSS in
> DOMUIThemeSource. It seems that each occurrence of the New Tab Page
> gets its own NewTabHTMLSource and DOMUIThemeSource objects, so the
> cache should be scoped to a single instance of a New Tab Page. I
> haven't experimented with Reload or tried other things that might
> abuse the cache.
The one that's easy to break is incognito: open one normal window, one
incognito, try refreshing the NTP on both. Check that this actually
works on trunk before you assume any breakage was introduced by you.
;)
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
