> 1) writers of patches don't mention that the patch is two-sided and
> will break Chromium if landed prematurely. I don't have to go far for
> an example. Commit queue bot landed
> http://trac.webkit.org/changeset/48659 a few minutes ago and broke the
> canary. This means that the canary will be red all night and any
> subsequent regressions will either not be noticed or create more
> complications.
As I found out later that night (as I was fixing the bustage), this
particular break wasn't due to the two-sided nature of the patch. It
was a couple of missing includes. Apologies for mis-placing it into
this category. This one was from the #2 pile :)
:DG<
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
