Maybe it's just me, but I don't see the point in making a toolbar as a whole focusable. The keyboard shortcut should put focus on the first element in the toolbar and tab should cycle focus from there.
> and when we press "ALT+T+TAB" ... I hope you mean "ALT+T and then TAB" because ALT+T+TAB is a pretty weird keyboard shortcut. :) On Thu, Oct 8, 2009 at 18:21, Mohamed Mansour <m...@chromium.org> wrote: > Hi everyone, > I was experimenting on how to visualize when we focus different tabs, and > (from a bug I was working on http://crbug.com/15228) I realized a few > stuff. If we enable "IsFocusable" for all the toolbars we have in Chromium, > we will have this "good" (or some people might be annoyed by it) focus bar > around the whole toolstrip. It looks like this: > > http://i37.tinypic.com/25ugpc0.png > > > What do you all think about having the focus ring when we traverse the > toolbars? I think it would be a nice additional. On a side note, the focus > ring only appears if you have pressed "ALT+SHIFT+T", otherwise no focus ring > will be shown. > > Since we agreed in this email that we will be having "ALT+SHIFT+T" + tab, > to traverse through all the tool bars, that is only valid for "forwards > traverses" not "backward traverses". How are we planning to do that? > > I suggest we do "ALT+T" to apply focus to the ToolBarView and when we press > "ALT+T+TAB" it will focus to the next tab, same thing with applying SHIFT > (go backwards). > > -Mohamed > > > > On Wed, Sep 30, 2009 at 11:10 AM, Scott Violet <s...@chromium.org> wrote: > >> Sounds good to me. >> >> -Scott >> >> On Tue, Sep 29, 2009 at 5:03 PM, Jonas Klink (Google) >> <kl...@chromium.org> wrote: >> > So, to clarify, we would then use ALT+SHIFT+T (currently focusing the >> > toolbar), to cycle keyboard focus through any open toolbars >> > (toolbar->bookmark bar->infobar (restore tabs etc, if >> visible)->Extensions >> > toolstrips). Does that makes sense to everyone? The shortcut is not >> ideal, >> > but it might be the best we've got... >> > >> > On Tue, Sep 29, 2009 at 4:26 PM, Scott Violet <s...@chromium.org> wrote: >> >> >> >> I would just use the existing accelerator we have to focus the toolbar. >> >> >> >> -Scott >> >> >> >> On Tue, Sep 29, 2009 at 3:58 PM, Mohamed Mansour <m...@chromium.org> >> wrote: >> >> > What kind of accelerators do would you like to have? Maybe have >> >> > a accelerator that traverses only toolbars, and once we are in that >> >> > toolbar, >> >> > we can tab through the widgets. >> >> > -Mohamed >> >> > >> >> > >> >> > On Tue, Sep 29, 2009 at 1:30 PM, Peter Kasting <pkast...@google.com> >> >> > wrote: >> >> >> >> >> >> On Tue, Sep 29, 2009 at 10:25 AM, Scott Violet <s...@chromium.org> >> >> >> wrote: >> >> >>> >> >> >>> On Tue, Sep 29, 2009 at 10:16 AM, Peter Kasting < >> pkast...@google.com> >> >> >>> wrote:> It seems like when these bars are open, their contents >> should >> >> >>> be in >> >> >>> the tab >> >> >>> > order. You should be able to tab through the contents of a page, >> >> >>> > into >> >> >>> > the >> >> >>> > chrome, and eventually back into the page. >> >> >>> >> >> >>> I don't think most folks want tab from the omnibox to take you >> through >> >> >>> the menus, then bookmark buttons. I know that would drive me batty. >> I >> >> >>> could see some users wanting it, but I don't think it should be the >> >> >>> default. >> >> >> >> >> >> I admit that I totally failed to think through "tab in the omnibox" >> -- >> >> >> I >> >> >> was thinking about all the other cases. >> >> >> That said, we've had TONS of requests to make tab from the omnibox >> work >> >> >> differently (i.e. "like how other browsers do it"): >> >> >> * When the popup is open, tab rotates through its items >> >> >> * Otherwise, tab moves to the next focusable element >> >> >> I kind of regret that we picked tab for "tab to search" because it >> >> >> prevents both of these, and I'm not sure we can change it now. It >> does >> >> >> seem >> >> >> like a bug somehow that you can tab into the omnibox but not out, >> but I >> >> >> don't know how to fix :( >> >> >>> >> >> >>> Perhaps we >> >> >>> also need the ability to assign accelerators to individual >> >> >>> bookmarks/extensions. >> >> >> >> >> >> This has been requested a few times, and brakowski suggested it long >> >> >> ago >> >> >> as a replacement for the "home" button -- if you can drag a bookmark >> >> >> onto >> >> >> your main toolbar, and give it an alt-home shortcut, then you have >> your >> >> >> own >> >> >> "home" button. >> >> >> PK >> >> > >> > >> > >> > > >> > >> > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
