On Nov 21, 2009, at 10:19 AM, Evan Martin wrote:
> We should whitelist known compiler versions that build successfully
> with -Werror, and then turn it off for the rest.
I did something in this spirit, though in kludgy form, a few weeks ago. After I
fixed all the current GCC warnings in WebCore, I turned on -Wall and -Werror in
the .gyp file, but only for the Mac platform.
It would be great if we had a coherent, organized way to do this kind of thing.
(And hopefully we'd keep -Werror enabled for all the platforms we officially
build on.)
>> There is another fix, which is to disable to warning within the file or
>> globally for GCC versions less than X.
>
> This works for warnings we know about now, but not warnings that will
> occur in the future, which is the larger problem.
It actually goes beyond warnings, unfortunately. Last week I checked in a patch
that turned out to cause a compile error under GCC 4.4 (due to some obscure
detail about template instantiation), which I didn't know about because the
Linux try bot builds with 4.2. I guess I'm saying that in general we can always
have problems with outlying compilers that our official build process doesn't
use, even if we don't enable -Werror.
I've said 'official' twice above, but I actually don't know what our policy is
about various compilers and versions. Is there an explicit list somewhere of
what compiler/platform combinations we support, i.e. commit to keep Chromium
working with?
—Jens
--
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
