[+chromium-dev] One issue is that even a smoke test wouldn't have caught this problem since as I said, it was windows specific. Maybe it's time to create a try server for depot_tools. :/
M-A On Sat, Nov 21, 2009 at 5:23 PM, Marc-Antoine Ruel <mar...@google.com> wrote: > I totally agree, I fully understand the pain I cause. :) > > In this particular case for example, the tool was broken on windows > only. Since I tested on linux, I didn't see the failure. I also ran > pychecker on the scripts last week and found at 2 lingering errors for > corner cases. > > I have a idea in the interim, I'll package a very small script that > sends me an IM whenever someone gets an exception in these scripts. > This way, the number of affected people should be much lower since > I'll be able to trap these faster, at least for "exception failures". > I'll kick my ass to add a full smoke test this year. > > When I replied to Munjal, I replied only to him by error. I only > realized when Munjal replied to the thread on chromium-dev that I > didn't cc chromium-dev. > > M-A > > On Sat, Nov 21, 2009 at 3:37 PM, John Abd-El-Malek > <jabdelma...@google.com> wrote: >> Marc-Antoine: let me preface this by saying I really appreciate all of your >> work on trybots + gcl, it makes our life better. >> I just hit this myself as well. I'm wondering if I can ask you to have a a >> small test case that you do which involves uploading, changing, and >> committing a change. The reason is I get so many failures, and with the >> size of the development team now, when the tool is broken it impacts a lot >> of engineers. >> Thanks, >> John >> >> On Sat, Nov 21, 2009 at 11:56 AM, Munjal Doshi <mun...@chromium.org> wrote: >>> >>> Just in case anyone else hit this, it was fixed in 32748. >>> -Munjal >>> >>> On Sat, Nov 21, 2009 at 10:04 AM, Evan Martin <e...@chromium.org> wrote: >>>> >>>> A guess, but it looks like it's attempting to find your email address >>>> out of your SVN authorization data, and that the computer you're on >>>> has no SVN auth data. Try something like "svn ls >>>> --username=mycommitern...@chromium.org svn://..." and log in if it >>>> prompts you. >>>> >>>> On Sat, Nov 21, 2009 at 12:46 AM, Munjal Doshi <mun...@chromium.org> >>>> wrote: >>>> > I get the following error when running gcl upload when it tries to send >>>> > the >>>> > job to try server after successfully uploading files: >>>> > Traceback (most recent call last): >>>> > File "C:\Tools\depot_tools\gcl.py", line 1273, in ? >>>> > sys.exit(main()) >>>> > File "C:\Tools\depot_tools\gcl.py", line 1244, in main >>>> > UploadCL(change_info, argv[3:]) >>>> > File "C:\Tools\depot_tools\gcl.py", line 865, in UploadCL >>>> > TryChange(change_info, trychange_args, swallow_exception=True) >>>> > File "C:\Tools\depot_tools\gcl.py", line 901, in TryChange >>>> > prog='gcl try') >>>> > File "C:\Tools\depot_tools\trychange.py", line 526, in TryChange >>>> > options.scm.ProcessOptions() >>>> > File "C:\Tools\depot_tools\trychange.py", line 177, in ProcessOptions >>>> > self.options.email = scm.SVN.GetEmail(gcl.GetRepositoryRoot()) >>>> > File "C:\Tools\depot_tools\scm.py", line 450, in GetEmail >>>> > for credfile in os.listdir(auth_dir): >>>> > WindowsError: [Errno 3] The system cannot find the path specified: >>>> > 'C:\\Users\\munjal\\AppData\\Roaming\\auth\\svn.simpl >>>> > e/*.*' >>>> > Does anyone know what hte problem is? >>>> > -Munjal >>>> > >>>> > -- >>>> > Chromium Developers mailing list: chromium-dev@googlegroups.com >>>> > View archives, change email options, or unsubscribe: >>>> > http://groups.google.com/group/chromium-dev >>> >>> -- >>> Chromium Developers mailing list: chromium-dev@googlegroups.com >>> View archives, change email options, or unsubscribe: >>> http://groups.google.com/group/chromium-dev >> > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev