It's really about the unit tests, not in chromium.

I guess we could probably leak the singleton in the unit tests too on
each reset. Pawel, what do you think?

Note to all the static local makers: you create an implicit atexit()
each time... Use a leaky singleton instead.

M-A

On Sun, Nov 22, 2009 at 7:47 PM, Peter Kasting <pkast...@google.com> wrote:
> On Sun, Nov 22, 2009 at 4:28 PM, Mike Belshe <mbel...@google.com> wrote:
>>
>> I think we should have a list of low-level functionality which we just
>> never cleanup.
>> For the items you listed, I think you should leak them all.  Trying to
>> cleanup these items creates complicated code and ultimately won't run any
>> better and possibly slower.
>
> +1 for leaking a much as possible on shutdown.  We should make sure we shut
> down anything that can write data to disk, and then just kill the process.
>  Right now I suspect we clean up much more stuff in the browser process than
> we have to.
> PK
>
> --
> Chromium Developers mailing list: chromium-dev@googlegroups.com
> View archives, change email options, or unsubscribe:
> http://groups.google.com/group/chromium-dev

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev

Reply via email to