Awesome! When can we land the patch. :) Adam
On Tue, Nov 24, 2009 at 2:42 PM, Anton Muhin <ant...@chromium.org> wrote: > So, I eventually managed to embed some DOM benchmarks into extension. > The patch I sent (with one fix) buys us roughly 20%, after it > benchmarks ran as a content script lag something like 4% compared to > same benchmarks ran w/o any content script. > > Detailed data: > https://spreadsheets.google.com/a/google.com/ccc?key=toKIzdJ38bMbcS7sBt6a-vQ > (sorry, Google-internal). > > I'd appreciate if someone would have look at extensions I wrote to > estimate how representative they are (they required minor tweaks to > benchmarks, changing top to parent due to another embedding): > http://www.corp.google.com/~antonm/extensions/ > > Overall, I'd suggest to add them to perf buildbots: as of current they > need some massaging to get rid of, e.g., absolute paths, but that > should be doable. Two problems I can immediately see: 1) they take a > notable amount of time, 2) I don't know if it's possible/easy to > install an extension into the test. > > Any comments are most appreciated, > yours, > anton. > > On Fri, Nov 6, 2009 at 7:46 AM, Adam Barth <aba...@chromium.org> wrote: >> Try running a DOM benchmark while there is a content script that's >> waiting for a message from a background page. >> >> Adam >> >> >> On Thu, Nov 5, 2009 at 12:12 PM, Anton Muhin <ant...@chromium.org> wrote: >>> Adam, all, >>> >>> I've got http://codereview.chromium.org/355047/ which should speed up >>> accessing isolated worlds (it at least passes layout tests). >>> >>> Could someone either see if it helps or give me instructions how to bench >>> it? >>> >>> yours, >>> anton. >>> >>> On Tue, Oct 27, 2009 at 8:04 PM, Anton Muhin <ant...@chromium.org> wrote: >>>> On Tue, Oct 27, 2009 at 8:00 PM, Adam Barth <aba...@chromium.org> wrote: >>>>> On Tue, Oct 27, 2009 at 9:52 AM, Anton Muhin <ant...@chromium.org> wrote: >>>>>> if we're sure accessing hidden property is a bottleneck, it should be >>>>>> easily solvable: for long time I was toying idea to compile this code >>>>>> into native, but didn't see compelling enough reason to do that. The >>>>>> easy way to measure it would be to hack stuff a bit and put data as in >>>>>> internal field or just add another getter to context. If you like, I >>>>>> can try to do something like that, but I need a simplistic benchmark >>>>>> to estimate performance gain. >>>>> >>>>> I suspect you'll see a performance gain on any simple DOM benchmark >>>>> that runs in the isolated world. That code path is hit on every >>>>> wrapper lookup. >>>> >>>> Ok, I will try to have a look at it this week. >>>> >>>> yours, >>>> anton. >>>> >>> >> > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
