Dear chromiumers,

Relatively recently I stopped seeing information about revisions for
build bot graphs.  If I open our debugger it reports something like:

Uncaught TypeError: Cannot call method 'slice' of undefined.

Line number it gives is incorrect.  Most probably it should be actually line 50:

function received_data(data) {
  var tbody = document.getElementById("tbody");
  data.replace('\r', '');

  var col_sums = [];
  var rows = data.split('\n');

  for (var i = 0; i < rows.length; ++i) {
    var tr = document.createElement("TR");

    var cols = rows[i].split(' ');

    // cols[0] = page name
    // cols[1] = (mean+/-standard deviation):
    // cols[2...] = individual runs

    // Require at least the page name and statistics.
    if (cols.length < 2)
      continue;

    var page = cols[0];
    var values = cols[1].split('+/-');
    append_column(tr, page, col_sums, -1);
    append_column(tr, values[0].slice(1), col_sums, 0);  // HERE WE'RE FAILING
    append_column(tr, values[1].slice(0,-2), col_sums, 1);

    for (var j = 2; j < cols.length; ++j)
      append_column(tr, cols[j], col_sums, j);

    tbody.appendChild(tr);
  }

It looks like data are returned in a wrong format.  Chances are it is
a problem with DOM or Dromaeo benchmarks, but I cannot see rev info
for other build bots either (e.g. Page Cycler Moz), there is no
exception however.

Any ideas what goes on?

yours,
anton.

-- 
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev

Reply via email to