> - fix the problem with the black scrollbars in testshell. This is easy. The > WebKit change currently sets all colors to zero, unless somebody explicitly > sets them to something else. We can pick different default values that will > at least make the scrollbars visible. This would still require rebasing the > pixel tests. And we have to make a decision on whether to apply this as an > incremental change or whether to rollback the current WebKit change. It's > gonna be a rely simple low-risk change.
Let's go with this. You'll have a chance all about the great rebaselining tool in the process. :) Michael will roll and add all the failures to expectations, creating a bug for you to rebaseline. :DG< > Markus > > On Tue, Dec 8, 2009 at 13:09, Dimitri Glazkov <dglaz...@chromium.org> wrote: >> >> Ouch. And all scrollbars in pixel tests are now black (see attached). >> Yeah, I think we should roll this one out. >> >> Welcome to the wonderful world of WebKit, Markus! >> >> :DG< >> >> On Tue, Dec 8, 2009 at 12:59 PM, Adam Langley <a...@google.com> wrote: >> > On Tue, Dec 8, 2009 at 12:55 PM, Michael Nordman <micha...@chromium.org> >> > wrote: >> >> yikes 481 failures on linux... k... holding off rolling until we get a >> >> handle on the nature of the linux borkage >> > >> > This is probably the result of Markus's first WebKit patch. It was >> > LGTMed and he asked that it be landed and didn't think that it would >> > break anything. >> > >> > However, it appears that he didn't know about the pixel tests! >> > >> > http://trac.webkit.org/changeset/51827 >> > >> > You might want to revert it for now, although it should be ok to >> > rebaseline any pixel tests that changed. It's just a very minor change >> > in the scrollbar colours. >> > >> > >> > AGL >> > > > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
