> > Anyhow, what's our best practices for disabling tests? I think ideally we'd > always log a tracking bug and add a comment, akin to what we do in the > test_expectations file for layout tests. This might be too much of a burden > on sheriffs, so an alternative is for people who are working on various > areas (like workers) track checkins to the associated files and add some > documentation after the fact. Or we can just live with the SVN logs, in > which case I need to get better about figuring out how to track through the > SVN/git history of the various files :) >
I wrote up this section under our Tree Sheriff page: http://dev.chromium.org/developers/tree-sheriffs#TOC-Disabling-tests In summary: writing a bug, copying+pasting output, and assigning an owner. For code that was recently checked in but the person doesn't want to revert, I tend to file the bug as a P1 + Regression label. Andrew -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev