[EMAIL PROTECTED] wrote:
> 07/12 - ckrm_configfs_rcfs
> 
> Create the filesystem(RCFS) for managing CKRM. Hooks up with configfs.
> Provides functions for creating and deleting classes.
> --
> 
> Signed-Off-By: Chandra Seetharaman <[EMAIL PROTECTED]>
> Signed-Off-By: Shailabh Nagar <[EMAIL PROTECTED]>
> Signed-Off-By: Matt Helsley <[EMAIL PROTECTED]>
> 
>  fs/Makefile      |    1 
>  fs/rcfs/Makefile |    1 
>  fs/rcfs/rcfs.c   |  160 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  init/Kconfig     |   12 ++++
>  4 files changed, 174 insertions(+)
> 
> Index: linux-2.6.16/init/Kconfig
> ===================================================================
> --- linux-2.6.16.orig/init/Kconfig
> +++ linux-2.6.16/init/Kconfig
> @@ -163,6 +163,18 @@ config CKRM
>         If you say Y here, enable the Resource Class File System and at least
>         one of the resource controllers below. Say N if you are unsure.
>  
> +config RCFS_FS
> +     bool "Resource Control File System (User API for CKRM)"
> +     depends on CKRM
> +     select CONFIGFS_FS
> +     default y
> +     help
> +       RCFS is the filesystem API for CKRM. Compiling it as a module permits
> +       users to only load RCFS if they intend to use CKRM.
> +
> +       Say M if unsure, Y to save on module loading. N doesn't make sense
> +       when CKRM has been configured.
> +

Why is RCFS_FS defined as bool, not tristate? If RCFS cannot be compiled
as a module from f0.5, I cannot come up with the reason why two
separated config options are needed for CKRM. IMHO, just CONFIG_CKRM is
enough and perhaps fs/rcfs/* should be relocated to kernel/ckrm/*.

# At least, it is inconsistent with the comment "Say M if unsure, ..."

Thanks,
MAEDA Naoaki




-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech

Reply via email to