On Mon, 2006-04-17 at 11:47 -0700, Chandra Seetharaman wrote:
> On Mon, 2006-04-17 at 17:00 +0900, MAEDA Naoaki wrote:
> > [EMAIL PROTECTED] wrote:
> > > 07/12 - ckrm_configfs_rcfs
> > >
> > > Create the filesystem(RCFS) for managing CKRM. Hooks up with configfs.
> > > Provides functions for creating and deleting classes.
> > > --
> > >
> > > Signed-Off-By: Chandra Seetharaman <[EMAIL PROTECTED]>
> > > Signed-Off-By: Shailabh Nagar <[EMAIL PROTECTED]>
> > > Signed-Off-By: Matt Helsley <[EMAIL PROTECTED]>
> > >
> > > fs/Makefile | 1
> > > fs/rcfs/Makefile | 1
> > > fs/rcfs/rcfs.c | 160
> > > +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > > init/Kconfig | 12 ++++
> > > 4 files changed, 174 insertions(+)
> > >
> > > Index: linux-2.6.16/init/Kconfig
> > > ===================================================================
> > > --- linux-2.6.16.orig/init/Kconfig
> > > +++ linux-2.6.16/init/Kconfig
> > > @@ -163,6 +163,18 @@ config CKRM
> > > If you say Y here, enable the Resource Class File System and at least
> > > one of the resource controllers below. Say N if you are unsure.
> > >
> > > +config RCFS_FS
> > > + bool "Resource Control File System (User API for CKRM)"
> > > + depends on CKRM
> > > + select CONFIGFS_FS
> > > + default y
> > > + help
> > > + RCFS is the filesystem API for CKRM. Compiling it as a module permits
> > > + users to only load RCFS if they intend to use CKRM.
> > > +
> > > + Say M if unsure, Y to save on module loading. N doesn't make sense
> > > + when CKRM has been configured.
> > > +
> >
> > Why is RCFS_FS defined as bool, not tristate? If RCFS cannot be compiled
>
> The reason i made it a bool is we merged ckrm_iface to rcfs, and
> ckrm_iface was using put_task_struct, which is not an exported symbol.
>
> May be we can add a new function to core, that takes a pid, instead of a
> task data struture, to set the class that does the get/put_task_struct.
>
> Comments anybody ?
I would rather see the options merged than add a function that takes a
pid. I don't think merging RCFS with the CKRM option adds much (if any)
overhead in the case that CKRM is unused, and keeping the interface as a
separate option doesn't seem necessary. Also, RCFS will only appear when
configfs gets mounted anyway.
Cheers,
-Matt Helsley
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech
