On 4/6/07, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote:
> On Fri, Apr 06, 2007 at 04:32:24PM -0700, [EMAIL PROTECTED] wrote:
> > +static int attach_task(struct container *cont, struct task_struct *tsk)
> > {
>
> [snip]
>
> > + task_lock(tsk);
>
> You need to check here if task state is PF_EXITING and fail with
> -ESRCH if so? Otherwise we risk breaking refcount on
> init_container_group.
>
Yes, I think you're right; I've now changed it to this in my tree:
task_lock(tsk);
if (tsk->flags & PF_EXITING) {
task_unlock(tsk);
put_container_group(newcg);
return -ESRCH;
}
rcu_assign_pointer(tsk->containers, newcg);
task_unlock(tsk);
Thanks,
Paul
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
ckrm-tech mailing list
https://lists.sourceforge.net/lists/listinfo/ckrm-tech
