Robert Schuster wrote:

Hi David,
yesterday we had a discusssion about stub methods and to-be-continued methods. I
think the one you tackled with looks like one.

+    if (defaultFileSystemView == null)
+      {
+        if (File.separator.equals("/"))
+          defaultFileSystemView = new UnixFileSystemView();
+        // else if (File.Separator.equals("\"))
+        //   return new Win32FileSystemView();
+ // else + // return new GenericFileSystemView();
+      }
+    return defaultFileSystemView;
  }
Am I right that the comments should suggest to implement a
Win32FileFileSystemView and a GenericFileSystemView() at some time?
I think that is right, but I can't be sure as I didn't write that commented-out code (I just moved it inside the if statement which is why it shows up on the diff).

If so it would be nice to have a FIXME telling that and a corresponding bug 
report.
Sure, I'll add those later today.

Regards,

Dave

cu
Robert





_______________________________________________
Classpath-patches mailing list
Classpath-patches@gnu.org
http://lists.gnu.org/mailman/listinfo/classpath-patches

Reply via email to