Hi, On Fri, 2005-12-16 at 16:48 +0100, Roman Kennke wrote: > I have put together a new proposal for the VM interface for > Plain(Datagram)SocketImpl. I incorporated most of Marks suggestions. > > 2005-12-16 Roman Kennke <[EMAIL PROTECTED]> > > * vm/reference/gnu/java/net/VMPlainSocketImpl.java: New VM > class. > * vm/reference/gnu/java/net/VMPlainDatagramSocketImpl.java: > New VM class. > * native/jni/java-net/gnu_java_net_VMPlainSocketImpl.c: New > file. > * native/jni/java-net/gnu_java_net_VMPlainDatagramSocketImpl.c: > New file. > * native/jni/java-net/gnu_java_net_PlainDatagramSocketImpl.c: > Removed. > * native/jni/java-net/gnu_java_net_PlainSocketImpl.c: Removed. > * native/jni/java-net/Makefile.am: Adjusted for new source > files. > * gnu/java/net/PlainDatagramSocketImpl.java: Use new VM > interface. > * gnu/java/net/PlainSocketImpl.java: Use new VM interface. > * include/gnu_java_net_PlainDatagramSocketImpl.h: Removed. > * include/gnu_java_net_PlainSocketImpl.h: Removed. > * include/gnu_java_net_VMPlainDatagramSocketImpl.h: New header > file. > * include/gnu_java_net_VMPlainSocketImpl.h: New header file. > > Is this ok to check in?
I think this is much cleaner then what we had. Thanks! Please do check it in. But I think we do want to make some small changes still to the interface. In particular how we handle the SEND_LOCK, timeouts (whether to use SO_TIMEOUT) and how to "cancel" a pending accept like Guilhem already said. It is probably easier to change that with this large patch out of the way when kaffe merges this in and/or when we merge this into libgcj. Cheers, Mark
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Classpath-patches mailing list Classpath-patches@gnu.org http://lists.gnu.org/mailman/listinfo/classpath-patches
