Mark Wielaard wrote: > On Wed, 2006-03-29 at 09:54 +0100, Gary Benson wrote: > > This patch makes Classpath do the right thing on GNU/Posix systems. > > It does look good to me. But in theory the usage of PATH_MAX might > be a problem. According to the glibc manual it might not be defined > if there is no limit on the file name and you should use pathconf() > to get limits in case there are different file systems with > different limits. But then you cannot/shouldn't allocate so much > memory since it might be huge. I don't know if this is a problem in > practice though. Anybody?
A lot of big projects (gcc, X, Python) do the following: #ifndef MAXPATHLEN #define MAXPATHLEN 4096 #endif I'm inclined to do the same (if it works for them...) but where should I put it? target_generic_file.h? > Could you also add a little note the the NEWS file under > Runtime/Platform interface changes? This ok? * The method gnu.java.io.PlatformHelper.toCanonicalForm() has been replaced with a JNI implementation of VMFile.toCanonicalForm() for GNU/Posix systems. Cheers, Gary
