On 5 Sep 2006, at 07:21, Mark Wielaard wrote:
On Mon, 2006-09-04 at 22:30 +0100, Andrew John Hughes wrote:
On Mon, 2006-08-21 at 02:56 +0200, Mark Wielaard wrote:
...
2006-08-20 Mark Wielaard <[EMAIL PROTECTED]>
...
* native/jni/java-lang/java_lang_VMProcess.c
(Java_java_lang_VMProcess_nativeSpawn): Remove redirect
argument.
...
* vm/reference/java/lang/VMProcess.java: Removed unused redirect
argument.
* include/java_lang_VMProcess.h: Regenerated.
Why has this been done? The files show no other changes and this has
broken the generics branch build.
Because we didn't realize it was actually useful or used. Sorry. I see
ProcessBuilder on the generics branch actually uses it. The native
code,
at least on the trunk didn't handle it at all. It was introduced after
the native branch was made and neither Guilhem or I realized this and
since there were other cleanup changes to these files we missed
this new
feature. Please do assign a bug to reintroduce this to me if you
cannot
easily fix this.
Cheers,
Mark
I'll reintroduce it on the branch first, which is where it is most
needed (so it will compile again),
and then port it back to HEAD.
Were there other changes to these files? The diff I looked at, of
VMProcess.java, only showed a removal of the redirect lines.
--
Andrew :)