> I was in the area, so I made this change, and re-factored a bit of
 > duplicate code in the process:
 > 
 > http://zhadum.east/ws/seb/seb-ipobs/webrev.ifaddr/

This looks good.  A few small comments (I realize you already integrated
this):

        * ipnet_if_add_ifaddr() doesn't return a value, so you can remove
          those casts to void and clean up some of the formatting a bit.

        * 1292: The `done' label in ipnet_addrchg_ev() is unused, but it
          seems maybe it should be used -- i.e., don't we need to drop the
          reference here?

-- 
meem

Reply via email to