On Mon, 2008-09-08 at 14:36 -0400, Peter Memishian wrote: > > I was in the area, so I made this change, and re-factored a bit of > > duplicate code in the process: > > > > http://zhadum.east/ws/seb/seb-ipobs/webrev.ifaddr/ > > This looks good. A few small comments (I realize you already integrated > this): > > * ipnet_if_add_ifaddr() doesn't return a value, so you can remove > those casts to void and clean up some of the formatting a bit. > > * 1292: The `done' label in ipnet_addrchg_ev() is unused, but it > seems maybe it should be used -- i.e., don't we need to drop the > reference here?
Agreed on both, and I'll fix both of these when I integrate my next change later today, which is to fix the non-global zone multicast bug (???6744709) that John found during testing. Thanks, -Seb
