On Sat, 2008-09-13 at 14:06 -0400, Peter Memishian wrote: > > I just pushed the work I'd been doing this week in clearview-ipobs: > > > > ??????6745423 snoop -P -I lo0 fails > > only track IP addresses that are up > > implement per-ill NIC event queue > > functional interface for ip_join_allmulti() > > more code-review cleanup > > implement SIGN() macro in sysmacro.h for convenient avl node comparisons > > > > The webrev of the change is contained here: > > > > http://zhadum/ws/seb/seb-ipobs/webrev.events/ > > This looks nice. I'm still not sold on the LIF_DOWN/LIF_UP hook placement > though -- what's the justification for routing sockets and and hooks > seeing a different view of when an address is up/added to the local IP > stack?
It's a good question. I tried to place each of these such that the events are only generated if the operation that prompts the event actually completes, as opposed to simply when an attempt the operation is made (the IPv4 events that Phil originally had were actually in the same place as they are now). There are cases in ipif_up_done*() where the IPIF_UP flag does not get set due to an error, but yet routing sockets has already sent up an IFINFO message. I think that routing sockets got this wrong. The sctp_update_ipif() function calls, however, seem to have gotten this right. Having just said that, I do notice some DAD-related calls to sctp_update_ipif(ipif, SCTP_IPIF_UP) that have no equivalent NE_LIF_UP events, so I'll take a look at those. -Seb
