On Sat, 2008-09-13 at 14:52 -0400, Peter Memishian wrote: > > > I think that routing sockets got this wrong. The sctp_update_ipif() > > function calls, however, seem to have gotten this right. > > I think you'll find the ip_rts_newaddrmsg() calls mirror the > sctp_update_ipif() calls.
Indeed they do. > > > Having just said that, I do notice some DAD-related calls to > > sctp_update_ipif(ipif, SCTP_IPIF_UP) that have no equivalent NE_LIF_UP > > events, so I'll take a look at those. > > Right, those are the DAD-related cases I mentioned above. I've fixed this up and coalesced all of the different notifications for IPIF_UP into a convenience function. I'm not quite sure about the NE_LIF_DOWN event. I've moved it so that it only gets generated when the ipif was previously up (which makes sense to me) where the sctp_update_ipif() call is, but the RTM_DELADDR message is at the bottom of ipif_down_tail() which doesn't seem right. http://zhadum.east.sun.com/ws/seb/seb-ipobs/webrev.lifup/ -Seb
