On Wed, 2008-11-19 at 19:04 -0500, Peter Memishian wrote:
> http://zhadum.east/ws/clearview/clearview-ipmpdev/webrev
>
> This also includes the other 4 bugs I've sent out requests for. All told,
> it's only 62 lines of code change, so it should be straightforward :-)
Looks good, one nit and one non-nit:
usr/src/cmd/cmd-inet/usr.sbin/ifconfig/ifconfig.c
* 2208-2211: The logical flow of this code is a little strange. I'd
find that a "goto fail" being the exception under a conditional to be
more readable:
if (nappaddr > 0)
goto fail;
break;
}
usr/src/uts/common/inet/dlpistub/dlpistub.c
* 105: should be "ds_dip = NULL"
-Seb
