> usr/src/cmd/cmd-inet/usr.sbin/ifconfig/ifconfig.c > > * 2208-2211: The logical flow of this code is a little strange. I'd > find that a "goto fail" being the exception under a conditional to be > more readable: > > if (nappaddr > 0) > goto fail; > break;
OK, though I'd rather use "continue" rather than "break" as the intent is to go back to the top of the while loop, rather than fall to the bottom and then return to the top. This is done in the other arms of the case statement. > usr/src/uts/common/inet/dlpistub/dlpistub.c > > * 105: should be "ds_dip = NULL" Indeed, already fixed. Thanks, -- meem
