Hi Bertrand > The required incubation DISCLAIMER was missing, I've just added it at > http://svn.apache.org/repos/asf/incubator/clerezza/trunk/DISCLAIMER I can't see it there yet. > > So -1 on the release, unfortunately, until that's fixed. Ok, I'll rollback, which gives also the opportunity to fix the issue Tsuy brought up. (That's the one I know how to fix, if anyone knows more about the problem Enrico has, please step forward!)
> > I also have a number of minor points: > > 1) The release archive should be named clerezza-something and not > parent-something. and probably also the folder name in the zip, but the we have a problem with the version number as this one only refers to the version of the parent. For the tag in svn I think we could just use the date but I wouldn't know how to do this with the assambly plugin. > > 2) At the root, both NOTICE and NOTICE.txt are present, only one > should be there. @daniel do you have any idea were the first comes from? > 3) Running RAT with "mvn -P rat verify" reports 44 unapproved > licenses, the exclusions list in parent/pom.xml probably needs some > adjustments. I though I've eventually got rid of them, but apparently reintroduced them by reactivating editing in the discobits editor. > > 4) The svn tag > http://svn.apache.org/repos/asf/incubator/clerezza/tags/parent-0.2-incubating/ > matches the archive content, but contains two stray files: > > in osgi.services: maven-eclipse.xml > in shell: maven-eclipse.xml > > (minor problem really, mentioning it because I saw it) > > 5) Is the notice in ext.org.json.simple/NOTICE.txt really required? > Unless I missed something, http://code.google.com/p/json-simple/ > doesn't seem to require it. Isn't it just good practice to indicate the source of copyright owner of included code in NOTICE.txt? The json simple one seems unnecessarily verbose though. > > 6) mvn3 build failed the first time with errors like > Running org.apache.clerezza.platform.typehandlerspace.TypeHandlerSpaceTest > 62 [main] INFO org.apache.clerezza.triaxrs.JaxRsHandler - Binding > application config: > org.apache.clerezza.platform.typehandlerspace.TypeHandlerSpaceTest$1@61c80b01 > (class org.apache.clerezza.platform.typehandlerspace.TypeHandlerSpaceTest$1) > 110 [main] INFO org.eclipse.jetty.util.log - Logging to > org.slf4j.impl.SimpleLogger(org.eclipse.jetty.util.log) via > org.eclipse.jetty.util.log.Slf4jLog > 119 [main] INFO org.eclipse.jetty.util.log - jetty-7.0.1.v20091125 > 145 [main] INFO org.eclipse.jetty.util.log - Started > [email protected]:8100 > 241 [main] INFO org.apache.clerezza.triaxrs.JaxRsHandler - Binding > application config: > org.apache.clerezza.platform.typehandlerspace.TypeHandlerSpaceTest$1@72e8a021 > (class org.apache.clerezza.platform.typehandlerspace.TypeHandlerSpaceTest$1) > 243 [main] INFO org.eclipse.jetty.util.log - jetty-7.0.1.v20091125 > 244 [main] WARN org.eclipse.jetty.util.log - FAILED > [email protected]:8100: java.net.BindException: Address > already in use > > That's on a fairly fast box, so maybe timing-related. Could be, if nothing else is using port 8100 it might not have been freed from an earlier test > > Restarting with mvn install -rf platform.typehandlerspace, the build passes. > > That's with Maven 3.0.3, java version "1.6.0_29", macosx 10.7.2 > > Thanks for preparing the release! Thanks for the review! Reto > -Bertrand
