[
https://issues.apache.org/jira/browse/CLK-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700199#action_12700199
]
Bob Schellink commented on CLK-520:
-----------------------------------
-1. There are serious problems with this issue:
- It will break existing applications styling
- Button is a core control of Click and it won't work on IE without JavaScript
hacks. What if the site is suppose to work without JavaScript?
> Button should be rendered as "button"
> -------------------------------------
>
> Key: CLK-520
> URL: https://issues.apache.org/jira/browse/CLK-520
> Project: Click
> Issue Type: Bug
> Reporter: Joseph Schmidt
>
> Button controls should be rendered as "button" HTML elements not as "input".
> The actual implementation seems to use "input" of type "button" but that is
> quite misleading since with
> that type of tag, it's not possible to embed icons or span tags or something
> else(the "button" tag would normally allow) in the button to make it look
> better or what the requirements ask.
> The "input" element seems to have only a "value" attribute.
> E.g. adding an icon before the button text (in the button body) it's a very
> common requirement (so I think it should work as default).
> Button tag also has "type" (e.g. of 'submit', 'cancel' , 'button'), so
> derived controls of class Button would behave as before.
> thanks,
> Joseph.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
