[ 
https://issues.apache.org/jira/browse/CLK-520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700454#action_12700454
 ] 

Joseph Schmidt commented on CLK-520:
------------------------------------

> > it's impossible to add an icon to it
> You can easily add an icon to input controls by using the CSS background 
> property. 
Unfortunately this won't do the trick for most cases, because CSS (as of 
supported by most browsers today) allows only one background file, and this is 
already required for the margins and the 3D effect of elements.

This is why the Button (as <button>) was invented in first place.

I think Click should be not just background compatible, but *correct* too.
With the above IE fix it would be background compatible to a great degree. With 
a rendering option:
e.g. boolean renderAsInput = true (default), could be 100% background 
compatible), but not so "clean" like a simple move to <button> tag.

thanks,
Joseph.

> Button should be rendered as "button"
> -------------------------------------
>
>                 Key: CLK-520
>                 URL: https://issues.apache.org/jira/browse/CLK-520
>             Project: Click
>          Issue Type: Bug
>            Reporter: Joseph Schmidt
>
> Button controls should be rendered as "button" HTML elements not as "input".
> The actual implementation seems to use "input" of type "button" but that is 
> quite misleading since with
> that type of tag, it's not possible to embed icons or span tags or something 
> else(the "button" tag would normally allow) in the button to make it look 
> better or what the requirements ask.
> The "input" element seems to have only a "value" attribute.
> E.g. adding an icon before the button text (in the button body) it's a very 
> common requirement (so I think it should work as default).
> Button tag also has "type" (e.g. of 'submit', 'cancel' , 'button'), so 
> derived controls of class Button would behave as before.
> thanks,
> Joseph.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to