On Tue, 13 Sep 2022 14:56:07 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> It is probably simpler but we already store all tha properties in the >> generated NimbusDefaults, I do not think we should split the storage in two >> parts. > > Properties are **already** being stored in two parts so I am not inventing it > for this fix. I am just adding an entry to the already created UIDefaults. > Also, as I told, storing a character in skin.laf involves changing the > generator tool which might not be scalable and prone to regressions, not to > mention what/where should be changed in the tool for this is not known to me. > > Also, as Synth is a skinnable look and feel, I think it would have been an > issue if the property to be added affects "skin" in anyways, like **color, > font, dimension** property etc, in which case it would have made sense to be > mandatorily put in skin.laf which is the "visual designer" > but this Password echo character property will not affect the skin in > anyway, like the other properties added in UIDefaults table in > SynthLookAndFeel, so I think it should be ok. I agree with @prsadhuk here. The `echoChar` isn't skin, it can be defined directly as is done for other properties. ------------- PR: https://git.openjdk.org/jdk/pull/10035
