On Wed, 28 Sep 2022 03:42:38 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Default echo character obtained through `PasswordField.echoChar` UIProperty >> returns null for Nimbus L&F, >> which is fixed by adding the default character * in the UIDefault table. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Review comment fix Marked as reviewed by aivanov (Reviewer). test/jdk/javax/swing/plaf/nimbus/PasswordFieldTest.java line 59: > 57: "PasswordField.echoChar returns null for " + > 58: laf.getClassName()); > 59: } A question of style: do we usually wrap lines before the operator or after? [Java Coding Style](https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html#248) is for the former. This versions seems to have been updated and the code formatting is lost now; [this draft](http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html#toc-wrapping-lines) is still for the same usage. ------------- PR: https://git.openjdk.org/jdk/pull/10035
