On Fri, 21 Oct 2022 22:51:49 GMT, Damon Nguyen <[email protected]> wrote:
>> Toshio Nakamura has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update testcase
>
> test/jdk/javax/swing/text/html/TestResetSelectForm.java line 93:
>
>> 91: if (getMaxColorDiff(baseColor, c) > LIMIT) {
>> 92: throw new RuntimeException("Unexpected List selection at
>> " +
>> 93: (i+1) + ", " + baseColor + "," + c);
>
> The points mentioned seem valid since I see the same things when I test it
> myself. OptionListModel's clearSelection is being called without the drawing
> updating. The fix seems logical and works as intended.
>
> Just to nitpick, adding a space before and after the '+' in '(i+1)' here
> would match the pattern of all the other additions.
@DamonGuy Thank you for the comments. Fixed.
-------------
PR: https://git.openjdk.org/jdk/pull/10685
