On Mon, 24 Oct 2022 02:06:23 GMT, Toshio Nakamura <tnakam...@openjdk.org> wrote:
>> When JEditorPane shown HTML form with multi-selection, the reset operation >> broke its data. >> >> The sample testcase were attached in JBS. The recreate steps are below: >> 1. The sample shows a multi-selection form with 5 items. >> 2. Select the 4th item. >> 3. Press the reset button. >> Actual: The 4th item is still selected. >> Expect: No item should be selected. Resetting operation may move to the >> initial state. The sample doesn't use 'selected' property in each option tag. >> 4. Just after the step 3, move the focus to outside of the application and >> back. >> Actual: The 2nd item is selected. It means inside data indicates so. >> Expect: No item is selected. >> >> There are two issues. The current method >> `OptionListModel.removeIndexInterval()` disabled selections, but it didn't >> fire the change. Then, no re-drawing. Another issue is the method works as >> remove and shift. Then, selection values were corrupted. >> I think the clear method `OptionListModel.clearSelection()` is suitable here. >> >> Test: jdk_desktop on macOS (x64, Monterey), Linux (x64, RHEL8), and Windows >> (x64, 2012R2). >> No regression found > > Toshio Nakamura has updated the pull request incrementally with one > additional commit since the last revision: > > Fixed space Marked as reviewed by dnguyen (Author). ------------- PR: https://git.openjdk.org/jdk/pull/10685
