On Tue, 1 Nov 2022 16:45:45 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Remove extra line
>
> test/jdk/javax/swing/JTable/JTableEditorNPE.java line 62:
> 
>> 60:             });
>> 61:         } finally {
>> 62:             Thread.sleep(1000);
> 
> Is the `sleep` required?
> 
> If NPE is thrown, no UI appears at all; if NPE is not thrown, the UI may be 
> shown but not required.
> 
> Would it be enough to add the table to the frame and call `validate()`?

I added sleep to see the frame before it dispose but I agree it's not required 
for checking the fix..Modified as per comment...

-------------

PR: https://git.openjdk.org/jdk/pull/10871

Reply via email to