On Fri, 10 Feb 2023 11:46:22 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> SwingWorker done() method [spec >> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452) >> says "Executed on the Event Dispatch Thread after the doInBackground method >> is finished" >> but there's no mechanism in place to honor that claim. >> The >> [spec](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L289) >> also says the state should be DONE after doInBackground() returns which is >> also not done. >> >> Modified the code to honour the specification. > > Prasanta Sadhukhan has updated the pull request incrementally with two > additional commits since the last revision: > > - Fix and test updated > - Fix and test updated test/jdk/javax/swing/SwingWorker/TestDoneBeforeDoInBackground.java line 29: > 27: * before the 'doInBackground' is finished > 28: * @run main TestDoneBeforeDoInBackground > 29: */ May I ask you to move the jtreg tags to the class declaration, please? When the file is opened in the IDE, they're not collapsed (together with the license block above) and easily accessible. ------------- PR: https://git.openjdk.org/jdk/pull/11940
