> The issue is in Aqua L&F when an editable JComboBox with a border is used. In 
> this case, when the comboBox is clicked for the drop-down menu to show, the 
> drop-down menu appears at the wrong coordinates (blocking the text of the 
> comboBox and making it unreadable).
> 
> This seems to have been the case for a while and a similar issue appeared 
> recently where an editable Aqua JComboBox also had wrong positioning due to 
> having a border.
> 
> This fix checks for a border and modifies the bounds to accommodate the 
> border's size. Then the usual calculations for the comboBox popup works as 
> expected.
> 
> The new headful test creates an editable comboBox with a TitledBorder and 
> with no border. Then, it automatically clicks the comboBox to open the popup, 
> and clicks where the position of the first selectionItem should be. Finally, 
> it checks if the selected item is correct. This is for all L&F's and the test 
> passes on all OS's.

Damon Nguyen has updated the pull request incrementally with one additional 
commit since the last revision:

  Update Mac test to match native

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12750/files
  - new: https://git.openjdk.org/jdk/pull/12750/files/c71b8fbb..76bac3a7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12750&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12750&range=04-05

  Stats: 35 lines in 1 file changed: 19 ins; 7 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/12750.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/12750/head:pull/12750

PR: https://git.openjdk.org/jdk/pull/12750

Reply via email to