On Mon, 13 Mar 2023 21:51:16 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove debug image > > test/jdk/javax/swing/JComboBox/EditableComboBoxPopupPos.java line 118: > >> 116: checkSelection(cb1Str, cb2Str); >> 117: >> 118: SwingUtilities.invokeAndWait(() -> frame.dispose()); > > `dispose()` will not be called if `checkSelection()` will throw an exception. > So you should at least call `checkSelection()` after frame disposal. > > But as Alexey already said, more robust way is to call it from finally block, > so we end up with a closed frame on any unexpected exception. Sure, I'll add this ------------- PR: https://git.openjdk.org/jdk/pull/12750
