On Fri, 21 Apr 2023 12:58:58 GMT, Renjith Kannath Pariyangad <[email protected]> wrote:
> Hi Reviewers, > Noticed this test case not verifying all the cases which is intended. > Modified it for improving the coverage for 3 type of popups (menu, context > menu and combobox). > > Evaluating conditions: > 1. Not enough space for showing popup downwards(default layout), it should > show upwards > 2. Window starts from negative position, Popup should show on visible area > > For achieving this following areas are modified > - Updated isPopupOnScreen by adding Additional checks (like the position of > combobox popup is always verified) > - Menu creation made as function and reused for all menu creation. > - Updated ComboPopupCheckListener class and modified its > popupMenuWillBecomeInvisible function. Made it as generic and it is capable > to evaluate any combo box's position if this class set as its listener. > - This test case is not intended for multi monitor setup so added a check for > identifying monitor, else error out. > - Updated CTRL_MASK to CTRL_DOWN_MASK for removing depreciation warnings and > removed some other warnings. > > Please review this > > Regards, > Renjith. The new version of the test fails for me on macOS because CTRL + DOWN key combination is reserved by the operating system. It is necessary to disable "Application windows" system key shortcut to execute the test without failure. An interesting thing is that the old version of the test works fine even if "Application windows" system key shortcut is enabled. I would suggest documenting (probably at testing.md/wiki page) that "Application windows" key shortcut should be disabled prior testing. ------------- Changes requested by dmarkov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13578#pullrequestreview-1418993631
